Beginner FriendlyFoundryNFT
100 EXP
View results
Submission Details
Severity: low
Invalid

'public` functions not used internally could be marked `external`

Instead of marking a function as public, consider marking it as external if it is not used internally.

  • Found in src/ChoosingRam.sol Line: 33

    function increaseValuesOfParticipants(uint256 tokenIdOfChallenger, uint256 tokenIdOfAnyPerticipent)
  • Found in src/ChoosingRam.sol Line: 83

    function selectRamIfNotSelected() public RamIsNotSelected OnlyOrganiser {
  • Found in src/Dussehra.sol Line: 52

    function enterPeopleWhoLikeRam() public payable {
  • Found in src/Dussehra.sol Line: 67

    function killRavana() public RamIsSelected {
  • Found in src/Dussehra.sol Line: 81

    function withdraw() public RamIsSelected OnlyRam RavanKilled {
  • Found in src/RamNFT.sol Line: 45

    function setChoosingRamContract(address _choosingRamContract) public onlyOrganiser {
  • Found in src/RamNFT.sol Line: 49

    function mintRamNFT(address to) public {
  • Found in src/RamNFT.sol Line: 63

    function updateCharacteristics(
  • Found in src/RamNFT.sol Line: 82

    function getCharacteristics(uint256 tokenId) public view returns (CharacteristicsOfRam memory) {
  • Found in src/RamNFT.sol Line: 86

    function getNextTokenId() public view returns (uint256) {
Updates

Lead Judging Commences

bube Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Info/Gas/Invalid according to docs

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.