First Flight #17: Dussehra

Summary

Dussehra:killRavana uses div arithmetic operations.

Vulnerability Details

Solidity does not support floating-point numbers and in Dussehra:killRavana using div arithmetic operations can produce floating-point result.

Impact

Any division operation will result in integer division, where the fractional part is truncated (i.e., rounded down), so if the the result of the division is a floating-point result the amount will be rounded down.

Tools Used

Manual review

Recommendations

To handle floating-point precision issues in Solidity, you can use fixed-point arithmetic. This involves representing all numbers as integers, scaled by a factor that represents the desired precision