Description: The deposit
function takes a deadline parameter, whose purpose according to the documentation is "The deadline for the transaction to be completed by", but this parameter is unused in the function, failing to check that deadline
has passed for the transaction, which can cause users to add liquidity to the pool even after the deadline, in market conditions where the deposit rate is not favorable.
Impact: Transactions could be sent when market conditions are unfavorable to deposit, even when adding a deadline
parameter.
Proof of Concept:
Compile the contracts by running forge compile
Output from the terminal can be used to observe that
Recommended Mitigation: Consider the following mitigation
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.