First Flight #18: T-Swap
First Flight #18
Beginner FriendlyDeFiFoundry
100 EXP
View results
Previous Next
Submission Details
Severity: low
Invalid

Unnecessary validation in `deposit` function

0x1912

Summary

Unnecessary validation is used in deposit function.

Vulnerability Details

deposit function uses revertIfZero to check if wethToDeposit is not zero.

function deposit(
uint256 wethToDeposit,
uint256 minimumLiquidityTokensToMint,
uint256 maximumPoolTokensToDeposit,
uint64 deadline // @audit this is not needed
)
external
revertIfZero(wethToDeposit) // @audit this is not needed
returns (uint256 liquidityTokensToMint)
{
__SNIP__
}

However, this validation is unnecessary because more strict validation is used inside the function.

if (wethToDeposit < MINIMUM_WETH_LIQUIDITY) {
revert TSwapPool__WethDepositAmountTooLow(
MINIMUM_WETH_LIQUIDITY,
wethToDeposit
);
}

As you can see in the code snippet above, 'wethToDeposit' must be greater than or equal to MINIMUM_WETH_LIQUIDITY(1e9).
Therefore, if this condition is met, wethToDeposit cannot be 0.
Therefore, the revertIfZero modifier is called unnecessarily.

Impact

Users end up consuming gas by calling unnecessary modifiers.

Tools Used

Manual review

Recommendations

Please remove modifier revertIfZero in the deposit function.

Updates

Appeal created

inallhonesty Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.