Submission Details
Severity:
Missing deadline check in `TSwapPool:: deposit` allows transactions to complete even after input deadline
Summary
deadline input is not utilized which can leads to user getting less lp tokens during highly volatile market conditions.
Vulnerability Details
Deposit function in TSwapPool has deadline parameter, which is good as mentioned in the docs.
The deadline for the transaction to be completed by. However, this input parameter remains unused during the execution.
Due to this, Users who will deposit assets to the pool at highly volatile market will be affected by getting unfavorable rates.
Impact
Transactions getting executed at unfavourable rates.
Tools Used
Manual Review
Recommendations
It can be fixed by following way -
function deposit(
uint256 wethToDeposit,
uint256 minimumLiquidityTokensToMint,
uint256 maximumPoolTokensToDeposit,
uint64 deadline
)
external
+ revertIfDeadlinePassed(deadline)
revertIfZero(wethToDeposit)
returns (uint256 liquidityTokensToMint)
{
/// other code as is
}
Updates
Appeal created
inallhonesty about 1 year ago
Submission Judgement Published Assigned finding tags:
`deposit` is missing deadline check causing transactions to complete even after the deadline
Rewards breakdown
nSLOC
276This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.