Submission Details
Severity:
The parameters for `TSwapPool::LiquidityAdded` are out of order
Summary
Values are in the incorrect order when the LiquidityAdded event emits in TSwapPool::_addLiquidityMintAndTransfer.
Vulnerability Details
The poolTokensToDeposit and wethToDeposit parameters should be swapped.
Impact
Incorrect event emission resulting in improper off-chain functions
Tools Used
Manual Review
Recommendations
Rearrange the parameters as follows:
- emit LiquidityAdded(msg.sender, poolTokensToDeposit, wethToDeposit);
+ emit LiquidityAdded(msg.sender, wethToDeposit, poolTokensToDeposit);
Updates
Appeal created
inallhonesty over 1 year ago
Submission Judgement Published Assigned finding tags:
`LiquidityAdded` event has parameters out of order
Rewards breakdown
nSLOC
276This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.