Submission Details
Severity:
`TswapPool::LiquidityAdded` event has out of order parameters
Description: Event LiquidityAdded has parameters declared in the following order event LiquidityAdded(address indexed liquidityProvider, uint256 wethDeposited, uint256 poolTokensDeposited) but when it is emitted in TswapPool::_addLiquidityMintAndTransfer it is emitted in wrong order emit LiquidityAdded(msg.sender, poolTokensToDeposit, wethToDeposit). poolTokensToDeposit should be in the third position.
Impact: Event emission is incorrect, leading to off-chain functions potentially malfunctioning.
Recommended Mitigation:
function _addLiquidityMintAndTransfer(
uint256 wethToDeposit,
uint256 poolTokensToDeposit,
uint256 liquidityTokensToMint
) private {
_mint(msg.sender, liquidityTokensToMint);
- emit LiquidityAdded(msg.sender, poolTokensToDeposit, wethToDeposit);
+ emit LiquidityAdded(msg.sender, wethToDeposit, poolTokensToDeposit);
// Interactions
i_wethToken.safeTransferFrom(msg.sender, address(this), wethToDeposit);
i_poolToken.safeTransferFrom(
msg.sender,
address(this),
poolTokensToDeposit
);
}
Updates
Appeal created
inallhonesty over 1 year ago
Submission Judgement Published Assigned finding tags:
`LiquidityAdded` event has parameters out of order
Rewards breakdown
nSLOC
276This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.