First Flight #18: T-Swap

First Flight #18
Beginner FriendlyDeFiFoundry
100 EXP
View results
Submission Details
Severity: low
Invalid

`PoolFactory::constructor` lacking zero address check for the `i_wethToken`

Description: Upon deploying PoolFactory contract there is lack of zero address check in the constuctor for the parameter of i_wethToken.

Impact: Can hinder protocol functionality

Proof of Concept:

function testLackZeroAddressCheck() public {
PoolFactory dummyFactory = new PoolFactory(address(address(0)));
assert(dummyFactory.getWethToken() == address(0));
}

Recommended Mitigation:

constructor(address wethToken) {
+ if(wethToken == address(0)) {
+ revert();
+ }
i_wethToken = wethToken;
}
Updates

Appeal created

inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.