First Flight #18: T-Swap

Summary

  ((inputReserves * outputAmount) * 10000) /
        ((outputReserves - outputAmount) * 997);

it should be 1000 on top in this equation

Vulnerability Details

Stealing funds from users, giving them wrong price.

Impact

Such miscalculations can lead to steal from users and loose all the credibility for protocol.

Tools Used

slither, code review

Recommendations

((inputReserves * outputAmount) * 1000) /
((outputReserves - outputAmount) * 997);