First Flight #18: T-Swap

First Flight #18
Beginner FriendlyDeFiFoundry
100 EXP
View results
Submission Details
Severity: medium
Valid

'TSwapPool:: deposit' is missing deadline check causing transactions to complete even after the deadline

Summary

'deposit' function accepts a deadline parameter, which according to the
documentation is "The deadline for the transaction to be completed by". However, this parameter is never used. As a consequence,operationrs that add liquidity to the pool mightbe executed at unexpected times, in market where the deposit rate is unfavorable.

Proof of Concept:

function deposit(
uint256 wethToDeposit,
uint256 minimumLiquidityTokensToMint,
uint256 maximumPoolTokensToDeposit,
uint64 deadline
)

Impact

Transactions could be sent when market conditions are unfavorable to deposit, even when adding a deadline parameter.

Recommendations

  • Include a revert if the deadline has passed.

Updates

Appeal created

inallhonesty Lead Judge 12 months ago
Submission Judgement Published
Validated
Assigned finding tags:

`deposit` is missing deadline check causing transactions to complete even after the deadline

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.