Submission Details
Severity:
[L-1] (TSwapPool:: LiquidityAdded event has parameters out of order
Summary
When the "LiquidityAdded event is emitted in the'TSwapPool: :_addLiquidityMintAndTransfer'
function, it logs values in an incorrect order. The 'poolTokensToDeposit' value should go in the third parameter position, whereas the wethToDeposit'
value should go second.
Impact
Event emission is incorrect, leading to off-chain functions potentially malfunctioning.
Tools Used
Recommendations
- emit LiquidityAdded (msg-sender, poolTokensToDeposit, wethToDeposit);
+ emit LiquidityAdded(msg-sender, wethToDeposit, poolTokensToDeposit);
Updates
Appeal created
inallhonesty about 1 year ago
Submission Judgement Published Assigned finding tags:
`LiquidityAdded` event has parameters out of order
Rewards breakdown
nSLOC
276This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.