First Flight #18: T-Swap

First Flight #18
Beginner FriendlyDeFiFoundry
100 EXP
View results
Submission Details
Severity: low
Valid

[L-1] (TSwapPool:: LiquidityAdded event has parameters out of order

Summary

When the "LiquidityAdded event is emitted in the'TSwapPool: :_addLiquidityMintAndTransfer'
function, it logs values in an incorrect order. The 'poolTokensToDeposit' value should go in the third parameter position, whereas the wethToDeposit'
value should go second.

Impact

Event emission is incorrect, leading to off-chain functions potentially malfunctioning.

Tools Used

Recommendations

- emit LiquidityAdded (msg-sender, poolTokensToDeposit, wethToDeposit);
+ emit LiquidityAdded(msg-sender, wethToDeposit, poolTokensToDeposit);
Updates

Appeal created

inallhonesty Lead Judge 12 months ago
Submission Judgement Published
Validated
Assigned finding tags:

`LiquidityAdded` event has parameters out of order

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.