First Flight #18: T-Swap

First Flight #18
Beginner FriendlyDeFiFoundry
100 EXP
View results
Submission Details
Severity: medium
Valid

`T-SwapPool : : Deposit` Missing deadline check

Summary T-SwapPool : : Deposit is missing deadline check causing transaction to complete after the deadline

Vulnerability DetailsThedeposit` function accept the deadline as a parameter which according to the documentation is "the deadline for the transaction to be complete by" but this parameter is never used. As a consequence operations that add liquidity to the pool might be executed at unexpected time

Impact Transaction could be sent when market condition is unfavorable to deposit

Tools Foundry Fuzz testing

##Recommendations Should add a check for deadline as we defined condition in the modifier revertIfDeadlinePassed(deadline)

Updates

Appeal created

inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

`deposit` is missing deadline check causing transactions to complete even after the deadline

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.