Submission Details
Severity:
deadline does not take effect in deposit()
Summary
deadline parameter does not take effect in deposit()
Vulnerability Details
When users deposit tokens to get some LPs, they will set one deadline, the deposit transaction will be expected to be executed before the deadline. The vulnerability is that function deposit() does not process the deadline parameter.
function deposit(
uint256 wethToDeposit,
uint256 minimumLiquidityTokensToMint,
uint256 maximumPoolTokensToDeposit,
// @audit, deadline does not work
uint64 deadline
)
Impact
The transaction may exist in the mempool for a long time. The related pool's share price changes a lot, maybe depositors don't want to deposit based on this case. This will be unfair for the depositors.
Tools Used
Manual
Recommendations
Add one modify check revertIfDeadlinePassed(deadline).
Updates
Appeal created
inallhonesty about 1 year ago
Submission Judgement Published Assigned finding tags:
`deposit` is missing deadline check causing transactions to complete even after the deadline
Rewards breakdown
nSLOC
276This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.