Submission Details
Severity:
The `TSwapPool::LiquidityAdded` event has parameters out of order
Summary
When the LiquidityAdded event is emitted in the TSwapPool::_addLiquidityMintAndTransfer function, it returns values in an incorrect order. The poolTokensToDeposit value and the wethToDeposit value should be swapped.
Vulnerability Details
The event information is incorrect, this leads to wrong off-chain information being output and any off-chain services relying on this information to potentially break.
event LiquidityAdded(
address indexed liquidityProvider,
uint256 wethDeposited,
uint256 poolTokensDeposited
);
Tools Used
--Foundry
Recommendations
It is recommended to swap the order of the poolTokensToDeposit and wethToDeposit parameters.
- emit LiquidityAdded(msg.sender, poolTokensToDeposit, wethToDeposit);
+ emit LiquidityAdded(msg.sender, wethToDeposit, poolTokensToDeposit);
Updates
Appeal created
inallhonesty about 1 year ago
Submission Judgement Published Assigned finding tags:
`LiquidityAdded` event has parameters out of order
Rewards breakdown
nSLOC
276This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.