First Flight #18: T-Swap

Summary :

The deposit function accepts a deadline parameter, which according to the documentation is “The deadline for the transaction to be completed by”.
However, this parameter is never used. As a consequence, operations that add liquidity to the pool might be executed at unexpected times,in market
conditions where the deposit rate is unfavorable.

Vulnerability Details :

The deadline parameter is unused.

Impact :

Transactions could be sent when market conditions are unfavorable to deposit, even when adding a deadline parameter.

Tools Used :

manual

Recommendations :

Consider making the following change to the function
function deposit(
uint256 wethToDeposit,
uint256 minimumLiquidityTokensToMint, // LP tokens -> if empty,we can pick 100% (100% == 17 tokens)
uint256 maximumPoolTokensToDeposit,
uint64 deadline
)
external
+ revertIfDeadlinePassed(deadline)
revertIfZero(wethToDeposit)
returns (uint256 liquidityTokensToMint)
{