First Flight #18: T-Swap

First Flight #18
Beginner FriendlyDeFiFoundry
100 EXP
View results
Submission Details
Severity: medium
Invalid

LP token name & symbol

Summary

If a user is creating a pool for an ERC20 token that noes not implement name() or symbol() the PoolFactory.createPool() will fail.

Vulnerability Details

In both cases bellow this code will fail if the target ERC20 does not implement the called function

In PoolFactory.createPool()

string memory liquidityTokenName = string.concat("T-Swap ", IERC20(tokenAddress).name());
string memory liquidityTokenSymbol = string.concat("ts", IERC20(tokenAddress).name());

Impact

Tools Used

Recommendations

Use try catch to handle such case.

Updates

Appeal created

inallhonesty Lead Judge 12 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.