Submission Details
Severity:
`TSwapPool.deposit` is missing a deadline check potentially result in users receiving fewer liquidity tokens than expected
Summary
In
TSwapPool.depositfunction, thedeadlineparameter is passed but not used, resulting in a missing deadline check. Consequently, a user can add liquidity at unexpected times when the deposit rate is unfavorable.
Vulnerability Details
function deposit(
uint256 wethToDeposit,
uint256 minimumLiquidityTokensToMint,
uint256 maximumPoolTokensToDeposit,
@> uint64 deadline //unused!
)
Impact
Users might inadvertently deposit at an unfavorable rate, resulting users receiving significantly fewer liquidity tokens than they would under normal conditions.
Tools Used
Manual review
Recommendations
Use the already implemented
revertIfDeadlinePassed.
function deposit(
uint256 wethToDeposit,
uint256 minimumLiquidityTokensToMint,
uint256 maximumPoolTokensToDeposit,
uint64 deadline
)
external
+ revertIfDeadlinePassed(deadline)
revertIfZero(wethToDeposit)
returns (uint256 liquidityTokensToMint)
{}
Updates
Appeal created
inallhonesty 12 months ago
Submission Judgement Published Assigned finding tags:
`deposit` is missing deadline check causing transactions to complete even after the deadline
Rewards breakdown
nSLOC
276This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.