First Flight #18: T-Swap

First Flight #18
Beginner FriendlyDeFiFoundry
100 EXP
View results
Submission Details
Severity: low
Invalid

Use `.symbol` instead of `.name` when assigning a value to `liquidityTokenSymbol` In `PoolFactory::createPool()`,

Summary

.symbol is used instead of .name when assigning a value to liquidityTokenSymbol In PoolFactory::createPool(),

Impact

Confusion.

Tools Used

Manual review.

Recommendations

To be more in line with the name of the variable (and intended use thereof), use .symbol instead of .name when assigning a value to liquidityTokenSymbol In PoolFactory::createPool()

- string memory liquidityTokenSymbol = string.concat("ts", IERC20(tokenAddress).name());
+ string memory liquidityTokenSymbol = string.concat("ts", IERC20(tokenAddress).symbol());
Updates

Appeal created

inallhonesty Lead Judge 11 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.