First Flight #18: T-Swap

First Flight #18
Beginner FriendlyDeFiFoundry
100 EXP
View results
Submission Details
Severity: low
Invalid

'deadline' Should be <=

Summary

the contract has a 'deadline' as a parameter. But use the < operator when checking for a deadline

Vulnerability Details

modifier revertIfDeadlinePassed(uint64 deadline) {
if (deadline < uint64(block.timestamp)) {
revert TSwapPool__DeadlineHasPassed(deadline);
}
_;

Recommendations

Change all > operators to >= when working with deadline parameter.

modifier revertIfDeadlinePassed(uint64 deadline) {
- if (deadline < uint64(block.timestamp)) {
+ if (deadline <= uint64(block.timestamp)) {
revert TSwapPool__DeadlineHasPassed(deadline);
}
_;
Updates

Appeal created

inallhonesty Lead Judge 11 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Deadline should include equality as well

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.