Submission Details
Severity:
`sellPoolTokens` is calculating w.r.to output instead of input
Summary
TSwapPoolTokens:sellPoolTokens() is called by user expecting protocol to give him weth by taking in his pool tokens i.e., he is trying to see pool tokens. instead, the sellPoolTokens is calling swapExactOutput() instead of swapExactInput considering user is inputing exact input tokens he wants to sell.
Also, the function should have a slippage protection additionally to protect user's from MEV attacks or any inflationary/deflationary attacks to help user get the value what he's expecting to get.
Recommendations
Make below code changes in TSwapPool.sol
function sellPoolTokens(
uint256 poolTokenAmount
) external returns (uint256 wethAmount) {
return
- swapExactOutput(...);
+ swapExactInput(...);
}
Updates
Appeal created
inallhonesty about 1 year ago
Submission Judgement Published Assigned finding tags:
`sellPoolTokens` mismatches input and output tokens causing users to receive the incorrect amount of tokens
Rewards breakdown
nSLOC
276This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.