First Flight #18: T-Swap

First Flight #18
Beginner FriendlyDeFiFoundry
100 EXP
View results
Submission Details
Severity: low
Valid

`TSwapPool::_addLiquidityMintAndTransfer' emits `LiquidityAdded` event with misMatched parameters

Summary

The LiquidityAdded event is emitted with mismatched parameters in the TSwapPool::_addLiquidityMintAndTransfer function. The poolTokensToDeposit and wethToDeposit parameters are swapped in the event emission.

Impact

Event emission with mismatched parameters can lead to confusion and misinterpretation of the event data by off-chain consumers.

Tools Used

Manual Review

Recommendations

- emit LiquidityAdded(msg.sender, poolTokensToDeposit, wethToDeposit);
+ emit LiquidityAdded(msg.sender, wethToDeposit, poolTokensToDeposit);
Updates

Appeal created

inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

`LiquidityAdded` event has parameters out of order

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.