TSwappPool::deposit
is missing deadline check, causing transactions to complete even after the deadline has passedDescription: The deposit
function accepts a deadline
parameter, which according to the documentation is "The deadline for the transaction to be completed by". But, it is never used in the function, as a consequence, transactions can be completed even after the deadline has passed, in market conditions where deposit rate is unfavorable.
Impact: Transactions could be sent when market conditons are unfavorable to deposit, even when adding a deadlie parameter.
Proof of Concept: The deadline
parameter is unused.
Recommended Mitigation:
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.