First Flight #18: T-Swap

Summary

Detects reentrancies that allow manipulation of the order or value of events.

Vulnerability Details

Reentrancy in TSwapPool:_swap(IERC20,uint256,IERC20,uint256) (src/TSwapPool.sol#383-412):
External calls:
- outputToken.safeTransfer(msg.sender,1_000_000_000_000_000_000) (src/TSwapPool.sol#400)
Event emitted after the call(s):
- Swap(msg.sender,inputToken,inputAmount,outputToken,outputAmount) (src/TSwapPool.sol#402-408)

Impact

An attacker will create reentrancy attacks on the aforementioned calls to manipulate the allocations of funds within the coontract.

Tools Used

Slither

Recommendations

Apply the check-effects-interactions pattern.