First Flight #18: T-Swap
First Flight #18
Beginner FriendlyDeFiFoundry
100 EXP
View results
Previous Next
Submission Details
Severity: low
Invalid

Incorrect token symbol assignment in `PoolFactory::createPool` function

4lifemen

Summary

The createPool function's liquidityTokenSymbol not being assigned properly, which can lead to incorrect symbol assignment for the liquidity tokens.

Vulnerability Details

Incorrect liquidityTokenSymbol

function createPool(address tokenAddress) external returns (address) {
...
string memory liquidityTokenName = string.concat("T-Swap ", IERC20(tokenAddress).name());
string memory liquidityTokenSymbol = string.concat("ts", IERC20(tokenAddress).name());
...
}

Impact

Incorrect assignment of the liquidity token symbol

Tools Used

  • Manual review

Recommendations

+ string memory liquidityTokenSymbol = string.concat("ts", IERC20(tokenAddress).symbol());
- string memory liquidityTokenSymbol = string.concat("ts", IERC20(tokenAddress).name());
Updates

Appeal created

inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.