Submission Details
Severity:
TSwapPool::deposit is missing deadline check causing transactions to complete even after the deadline
Description: The deposit function accepts a deadline parameter, which according to the documentation is "The deadline for the transaction to be completed by". However, this parameter is never used. As a consequence, operations that add liquidity to the pool might be executed at unexpected times, in market conditions where the deposit rate is unfavorable.
Impact: Transactions could be sent when market conditions are unfavorable to deposit, even when adding a deadline parameter.
Proof of Concept: The deadline parameter is unused.
Recommended Mitigation: Consider making the following changes to the function.
function deposit(
uint256 wethToDeposit,
uint256 minimumLiquidityTokensToMint,
uint256 maximumPoolTokensToDeposit,
uint64 deadline
)
external
+ revertIfDeadlinePassed(deadline) // add this line
revertIfZero(wethToDeposit)
returns (uint256 liquidityTokensToMint)
{
Updates
Appeal created
inallhonesty about 1 year ago
Submission Judgement Published Assigned finding tags:
`deposit` is missing deadline check causing transactions to complete even after the deadline
Rewards breakdown
nSLOC
276This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.