First Flight #18: T-Swap

First Flight #18
Beginner FriendlyDeFiFoundry
100 EXP
View results
Submission Details
Severity: low
Invalid

PoolFactory::create is working wrong because of a one line in the function which causes it to change the name of the token

Description: The PoolFactory::create function inside it, it has initialized a new variable named liquidityTokenSymbol in which it uses the IERC20(tokenAddress).name() where it should be symbol not .name(), because if it is name then we can change the name and it would be anything but here in the protocol we are making token so it's symbol name should be used.

Impact: LOW because it will not cost more problem rather than having a different name.

Recommended Mitigation:

- string memory liquidityTokenSymbol = string.concat("ts", IERC20(tokenAddress).name());
+ string memory liquidityTokenSymbol = string.concat("ts", IERC20(tokenAddress).symbol());
Updates

Appeal created

inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.