First Flight #19: Mondrian Wallet v2

Summary

Need proxy even if in uups you have upgradeable functionality in implementation proxy is needed still.

Vulnerability Details

Lack of proxy contract

Impact

This contract will be not usable without proxy as it has disableInitializers in constructor

Tools Used

Recommendations

Use some proxy after you deploy implementation/logic contract deploy proxy

// SPDX-License-Identifier: MIT

pragma solidity ^0.8.0;

import "@openzeppelin/contracts/proxy/ERC1967/ERC1967Proxy.sol";

contract UUPSProxy is ERC1967Proxy { constructor(address logic, bytes memory data)

ERC1967Proxy(logic, data) {}

}

maybe with just delegate function, and keep upgradebility in uups contract of wallet.