Submission Details
Severity:
`MondrianWallet2::_authorizeUpgrade` is missing access contraol
Summary
The MondrianWallet2::_authorizeUpgrade function is missing access controls.
Vulnerability Details
Because there are no access controls on the _authorizeUpgrade function, anyone can call it and upgrade the contract.
// Needed for UUPS
@> function _authorizeUpgrade(address newImplementation) internal override {}
Impact
Without an onlyOwner modifier on the _authorizeUpgradefunction, anyone will be able to call it and upgrade the contract.
Tools Used
--Foundry
Recommendations
It is recommended to add an onlyOwner modifier to protect the function from being called by anyone.
- function _authorizeUpgrade(address newImplementation) internal override {}
+ function _authorizeUpgrade(address newImplementation) internal override onlyOwner {}
Updates
Lead Judging Commences
bube 11 months ago
Submission Judgement Published Assigned finding tags:
Lack of access control in _authorizeUpgrade
Rewards breakdown
nSLOC
105This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.