Hello ArkProject,
if the ERC721 metadata retrieval fails in the depositTokens
function, the code should revert the transaction to prevent further issues.
Mitigation: Ensure that all potential error scenarios are covered and appropriately handled with reverts or error messages to prevent unintended consequences.
Please, do not suppose impacts, think about the real impact of the bug and check the CodeHawks documentation to confirm: https://docs.codehawks.com/hawks-auditors/how-to-determine-a-finding-validity A PoC always helps to understand the real impact possible.
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.