NFTBridge
60,000 USDC
View results
Submission Details
Severity: low
Invalid

ERC1155 Batch Transfer Handling missing in Escrow contract

The current implementation of _depositIntoEscrow and _withdrawFromEscrow assumes individual transfers of ERC1155 tokens. However, the ERC1155 standard also allows for batch transfers. If an attacker transfers tokens in a batch, this could lead to unexpected behavior or security issues.

Mitigation: Consider implementing batch handling functions or explicitly reject batch transfers within these functions to ensure that the logic only processes single-token transfers.

Updates

Lead Judging Commences

n0kto Lead Judge 9 months ago
Submission Judgement Published
Invalidated
Reason: Out of scope
Assigned finding tags:

invalid-ERC1155-not-in-scope

```compatibilities: Blockchains: - Ethereum/Starknet Tokens: - [ERC721](www.tokenstandard.com) ``` ``` function depositTokens( uint256 salt, address collectionL1, snaddress ownerL2, uint256[] calldata ids, bool useAutoBurn ) external payable { if (!Cairo.isFelt252(snaddress.unwrap(ownerL2))) { revert CairoWrapError(); } if (!_enabled) { revert BridgeNotEnabledError(); } CollectionType ctype = TokenUtil.detectInterface(collectionL1); if (ctype == CollectionType.ERC1155) { @> revert NotSupportedYetError(); } … } ```

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.