NFTBridge
60,000 USDC
View results
Submission Details
Severity: medium
Valid

Users cannot withdraw their tokens if the bridge is disabled

Summary

Users cannot withdraw their tokens if the bridge is disabled.

Vulnerability Details

The intended behavior, as confirmed by the sponsor, is that users should be able to withdraw their tokens regardless of the bridge's enabled or disabled status. However, the current implementation incorrectly restricts token withdrawals when the bridge is disabled, contradicting this intended behavior.

Impact

Users are unable to withdraw their tokens when the bridge is disabled, which is inconsistent with the expected behavior.

Recommendation

  1. Remove the Bridge Status Check: If you check cancellation functions they don't have the bridge enable/disable check so similarly modify the withdrawTokens function to remove the check for the bridge's enabled/disabled status. This will ensure that users can withdraw their tokens regardless of the bridge's status.

  2. Apply Fix to Cairo Bridge Contract: Ensure that the same fix is applied to the Cairo bridge contract to maintain consistency across implementations.

  3. Test Changes: Thoroughly test the updated implementation to confirm that the withdrawal process works as intended in all scenarios.

Updates

Lead Judging Commences

n0kto Lead Judge about 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

finding-users-cannot-withdraw-while-bridge-disabled

Impact: Medium, token won’t be withdrawable until the bridge is enabled again. No real token loss. Likelyhood: Low/Medium, bridge would be disabled in case of emergency/upgrade/audit.

Appeal created

0xtheblackpanther Submitter
about 1 year ago
n0kto Lead Judge
12 months ago
n0kto Lead Judge 12 months ago
Submission Judgement Published
Validated
Assigned finding tags:

finding-users-cannot-withdraw-while-bridge-disabled

Impact: Medium, token won’t be withdrawable until the bridge is enabled again. No real token loss. Likelyhood: Low/Medium, bridge would be disabled in case of emergency/upgrade/audit.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.