Not be able to safe transfer ERC1155 tokens to bridge
Summary
Unable to deposit ERC1155 token to the bridge due to the bridge does not implement the onERC1155Received interface. As the protocol tends to support ERC1155 in the future, this could be a minor.
Vulnerability Details
The Escrow::_depositIntoEscrow() function safeTransferFrom 1 token to the bridge. However the bridge does not implement the onERC1155Received, resulting in transaction being reverted:
Impact
Unable to deposit ERC1155 to the bridge when the bridge adds the ERC1155 support.
Tools Used
vscode
Recommendations
Implement the onERC1155Received and onERC1155BatchReceived.
Lead Judging Commences
invalid-ERC1155-not-in-scope
```compatibilities: Blockchains: - Ethereum/Starknet Tokens: - [ERC721](www.tokenstandard.com) ``` ``` function depositTokens( uint256 salt, address collectionL1, snaddress ownerL2, uint256[] calldata ids, bool useAutoBurn ) external payable { if (!Cairo.isFelt252(snaddress.unwrap(ownerL2))) { revert CairoWrapError(); } if (!_enabled) { revert BridgeNotEnabledError(); } CollectionType ctype = TokenUtil.detectInterface(collectionL1); if (ctype == CollectionType.ERC1155) { @> revert NotSupportedYetError(); } … } ```
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.