ArkProject: NFT Bridge
ArkProject
NFTBridge
60,000 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

Typo in the L1L2CollectionMappingUpdated event leads to the event not being emitted properly

0xasen

Summary

There's a typo in the L1L2CollectionMappingUpdated event that leads to the event not being emitted properly.

Vulnerability Details

IStarklaneEvent.sol is in scope.

The event is emitted when the setL1L2CollectionMapping function is invoked in the Bridge.sol contract:

function setL1L2CollectionMapping(
address collectionL1,
snaddress collectionL2,
bool force
) external onlyOwner {
_setL1L2AddressMapping(collectionL1, collectionL2, force);
emit L1L2CollectionMappingUpdated(collectionL1, snaddress.unwrap(collectionL2));
}

However, there's a typo in the event:

event L1L2CollectionMappingUpdated(
address indexed colllectionL1, <---
uint256 indexed collectionL2
);

Which leads to the event not being emitted properly and if any systems are listening to these events or will listen to the event in the future will index the data incorrectly.

Impact

Event is emitted incorrectly leading to systems not indexing it correctly if such systems listen to these events.

Tools Used

Manual review

Recommendations

Correct colllectionL1 to collectionL1.

Updates

Lead Judging Commences

n0kto Lead Judge 10 months ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.