ArkProject: NFT Bridge
ArkProject
NFTBridge
60,000 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

[Infomational-1] : `depositfunctions` in the `bridge.sol` can be written better to save gas for wrong aribitary values

calc1f7r

Informational/Gas Optimization

Function in the src/bridge.sol can be written better to save the user gas when passed some arbitrary wrong values like the the nft collection has been been allowed to be transfered using Erc721.transferFrom function.

Result : If anything goes wrong first, executing _depositIntoEscrow(ctype, collectionL1, ids);
will do an revert, causing the gas to be sent to the inilizer.

Impact

Severity : None

Livelihood : None

function depositTokens(
uint256 salt,
address collectionL1,
snaddress ownerL2,
uint256[] calldata ids,
bool useAutoBurn
)
external
payable
{
if (!Cairo.isFelt252(snaddress.unwrap(ownerL2))) {
revert CairoWrapError();
}
​
if (!_enabled) {
revert BridgeNotEnabledError();
}
​
CollectionType ctype = TokenUtil.detectInterface(collectionL1);
​
if (ctype == CollectionType.ERC1155) {
revert NotSupportedYetError();
}
​
if (!_isWhiteListed(collectionL1)) {
revert NotWhiteListedError();
}
// @note depositing the tokens early to check if the user has approved the bridge to transfer or not
​
_depositIntoEscrow(ctype, collectionL1, ids);
​
Request memory req;
​
req.header = Protocol.requestHeaderV1(ctype, useAutoBurn, false);
​
req.hash = Protocol.requestHash(salt, collectionL1, ownerL2, ids);
​
req.collectionL1 = collectionL1;
req.collectionL2 = _l1ToL2Addresses[collectionL1];
​
req.ownerL1 = msg.sender;
req.ownerL2 = ownerL2;
​
if (ctype == CollectionType.ERC721) {
(req.name, req.symbol, req.uri, req.tokenURIs) = TokenUtil.erc721Metadata(
collectionL1,
ids
);
} else {
(req.uri) = TokenUtil.erc1155Metadata(collectionL1);
}
​
​
req.tokenIds = ids;
​
uint256[] memory payload = Protocol.requestSerialize(req);
​
if (payload.length >= MAX_PAYLOAD_LENGTH) {
revert TooManyTokensError();
}
​
IStarknetMessaging(_starknetCoreAddress).sendMessageToL2{value: msg.value}(
snaddress.unwrap(_starklaneL2Address),
felt252.unwrap(_starklaneL2Selector),
payload
);
​
emit DepositRequestInitiated(req.hash, block.timestamp, payload);
}
Updates

Lead Judging Commences

n0kto Lead Judge 11 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Informational / Gas

Please, do not suppose impacts, think about the real impact of the bug and check the CodeHawks documentation to confirm: https://docs.codehawks.com/hawks-auditors/how-to-determine-a-finding-validity A PoC always helps to understand the real impact possible.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.