NFTBridge
60,000 USDC
View results
Submission Details
Severity: low
Invalid

Unrestricted Access to cancelRequest Function

Summary

The cancelRequest function allows any user to cancel a request without proper access control, leading to potential misuse. While the intent might be that only the request originator can cancel it, the function lacks a mechanism to enforce this.

Impact

Unauthorized request cancellations

Recommendations

Add access control to ensure that only the originator or an authorized entity can cancel a request.

Updates

Lead Judging Commences

n0kto Lead Judge 9 months ago
Submission Judgement Published
Invalidated
Reason: Lack of quality
Assigned finding tags:

invalid-cancel-callable-by-anyone

The process to cancel a message is detailed here: https://docs.starknet.io/architecture-and-concepts/network-architecture/messaging-mechanism/#l2-l1_message_cancellation Since `startRequestCancellation` has the `onlyOwner`, only the owner can begin that process.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.