No Check on ERC1155 Metadata in `depositTokens`
Summary
The depositTokens function calls TokenUtil.erc1155Metadata(collectionL1) without checking if the metadata is valid or if the ERC1155 token is properly configured. If the metadata retrieval fails or returns incorrect data, it could cause issues with the deposit process.
Recommendations
Implement a validation step to ensure the ERC1155 metadata is valid and the tokens are correctly configured before proceeding with the deposit.
Lead Judging Commences
invalid-ERC1155-not-in-scope
```compatibilities: Blockchains: - Ethereum/Starknet Tokens: - [ERC721](www.tokenstandard.com) ``` ``` function depositTokens( uint256 salt, address collectionL1, snaddress ownerL2, uint256[] calldata ids, bool useAutoBurn ) external payable { if (!Cairo.isFelt252(snaddress.unwrap(ownerL2))) { revert CairoWrapError(); } if (!_enabled) { revert BridgeNotEnabledError(); } CollectionType ctype = TokenUtil.detectInterface(collectionL1); if (ctype == CollectionType.ERC1155) { @> revert NotSupportedYetError(); } … } ```
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.