NFTBridge
60,000 USDC
View results
Submission Details
Severity: high
Invalid

UUPSProxied.sol - SWC-112: Ensure only authorized upgrades occur.,SWC-114: Can introduce risks if not handled properly.

  • Summary: Implements UUPS proxy pattern.

  • Vulnerability Details:

    • Upgradeability Checks: SWC-112: Ensure only authorized upgrades occur.
      Severity: High

      require(msg.sender == admin, "Unauthorized upgrade");

      Line: 74

    • Delegatecall Risks: SWC-114: Can introduce risks if not handled properly.
      Severity: High

      (bool success, ) = implementation.delegatecall(data);

      Line: 92

  • Impact: Unauthorized upgrades or corrupted state.

  • Tools Used: Manual code inspection.

  • Recommendations:

    • Upgradeability Fix: Apply stricter checks on upgrades.

      require(hasRole(UPGRADER_ROLE, msg.sender), "Unauthorized upgrade");
    • Delegatecall Fix: Ensure safe usage of delegatecall.

      (bool success, ) = implementation.delegatecall(data);
Updates

Lead Judging Commences

n0kto Lead Judge 9 months ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.