Summary

In Bridge.sol in the depositTokens function, if ids is empty then _depositIntoEscrow will fail on the condition assert(ids.length > 0). This works as intended but will guzzle all the remaining gas of the user, instead you can make use of require to refund the remaining gas to the user.

Vulnerability Details

The assert statement in Solidity will consume all remaining gas if the condition fails. This is because assert is intended for internal errors and invariants, and it reverts the transaction with a state change rollback, consuming all remaining gas

Impact

Loss of gas

Tools Used

Manuel review

Recommendations

Replace the assert statement with a require statement to ensure that the function reverts with an appropriate error message and returns the remaining gas to the caller if ids.length is 0. require(ids.length > 0, "Escrow: ids array is empty");