NFTBridge
60,000 USDC
View results
Submission Details
Severity: low
Invalid

NFTs originally from L2 will have no tokenURI on L1

Summary

NFTs originally from L2 will have no tokenURI on L1.

Vulnerability Details

In Bridge.sol at no point does it update the URI for collections originating from L1

Impact

Users will be unable to see the image for their NFT.

Tools Used

Manual Review

Recommendations

The baseURI and tokenURI is already sent from the l2 so for most collections all that is needed is to update the baseURI on l1 if it is empty.

There is a potential danger with the token being unable to be transfered back if the URI is to big.

Updates

Lead Judging Commences

n0kto Lead Judge 9 months ago
Submission Judgement Published
Invalidated
Reason: Design choice
Assigned finding tags:

invalid-NFT-minted-without-baseURI-URIs-or-bridge-with-no-metadata

URI is not lost on the origin chain and it can be modified with `ERC721UriImpl`. As explained in the TODO  below, that’s a design choice and it will be implemented as a future feature. https://github.com/Cyfrin/2024-07-ark-project/blob/main/apps/blockchain/ethereum/src/Bridge.sol#L206 `ERC721Bridgable` is out of scope.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.