60,000 USDC
Submission Details
Severity:
use of `safeTransferFrom` in `cancelRequest` function could cause loss of nft
Github Links
https://github.com/Cyfrin/2024-07-ark-project/blob/main/apps/blockchain/ethereum/src/Bridge.sol#L254
https://github.com/Cyfrin/2024-07-ark-project/blob/main/apps/blockchain/ethereum/src/Escrow.sol#L79
Summary
The cancelRequest function uses the safeTransferFrom method to return nfts to owners if bridge tx fails. If the caller is a contract that holds nfts but doesn't implement _checkOnERC721Received and their bridge transaction is not successful, they will be unable to call the cancelRequestfunction as it will revert when the bridge attempts to send it back.
Impact
loss of nft
Recommendations
Use the transferFrommethod when returning tokens in the cancelRequestfunction
Prize pool breakdown
Total prize
60,000 USDC
nSLOC
2,30126
USDC / LOC
50,000 USDC
5,500 USDC
4,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.