NFTBridge
60,000 USDC
View results
Submission Details
Severity: medium
Invalid

`new_owners` used wrong address type in request.cairo

Summary

new_owners used wrong address type in request.cairo.

Vulnerability Details

request.cairo

struct Request {
........
........
........
// New owners on starknet. This allows a batch migration of the tokens to
// different owners.
// Must be empty if `owner_l2` is not 0. Otherwise, length must match `ids`.
@> new_owners: Span<ContractAddress>,
}

In request.cairo, new_owners use Span<ContractAddress> as address type. This is wrong.
L2's request is used to bridge from L2 to L1. So new owners are L1 address.

Impact

new_owners address type is wrong. L1 can't handle this address.

Tools Used

manual

Recommendations

struct Request {
........
........
........
// New owners on starknet. This allows a batch migration of the tokens to
// different owners.
// Must be empty if `owner_l2` is not 0. Otherwise, length must match `ids`.
- new_owners: Span<ContractAddress>,
+ new_owners: Span<EthAddress>,
}
Updates

Lead Judging Commences

n0kto Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Appeal created

0x996 Submitter
about 1 year ago
n0kto Lead Judge
about 1 year ago
n0kto Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.