Confusing naming: `enable_white_list` should be called `set_white_list`
Summary
The function enable_white_list in bridge.cairo has a confusing name and should be renamed to better reflect its purpose.
Vulnerability Details
The current function name, enable_white_list, suggests that it might only enable the whitelist. However, it actually sets the whitelist state based on the enable boolean parameter. This can cause confusion for developers and lead to misunderstandings about the function's purpose.
Impact
Misleading function names can lead to incorrect usage, making the codebase harder to maintain and potentially causing logical errors.
Recommendations
Rename the function from enable_white_list to set_white_list to accurately convey that it sets the whitelist status, enhancing code clarity and reducing the risk of errors.
Lead Judging Commences
Informational / Gas
Please, do not suppose impacts, think about the real impact of the bug and check the CodeHawks documentation to confirm: https://docs.codehawks.com/hawks-auditors/how-to-determine-a-finding-validity A PoC always helps to understand the real impact possible.
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.