NFTBridge
60,000 USDC
View results
Submission Details
Severity: low
Invalid

Lack of Input Validation in addMessageHashForAutoWithdraw

https://github.com/Cyfrin/2024-07-ark-project/blob/273b7b94986d3914d5ee737c99a59ec8728b1517/apps/blockchain/ethereum/src/Messaging.sol#L46

Description: The addMessageHashForAutoWithdraw function does not validate the msgHash parameter. It's assumed to be a valid 256-bit hash, but there's no explicit check to ensure this.

  • Impact: If an invalid or malformed hash is provided, it could lead to unexpected behavior or potential storage issues within the contract. The impact is likely low, but it's still good practice to include input validation.

  • Recommendation: Add a simple check to ensure that the msgHash is indeed a 256-bit value before processing it.

Updates

Lead Judging Commences

n0kto Lead Judge 11 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Informational / Gas

Please, do not suppose impacts, think about the real impact of the bug and check the CodeHawks documentation to confirm: https://docs.codehawks.com/hawks-auditors/how-to-determine-a-finding-validity A PoC always helps to understand the real impact possible.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.