Low-1

Summary

The msg.value can be less than the specified in the Starknet messaging protocol function.

Vulnerability Details

In the deposit function in L1 bridge.sol the msg.value is not validated according to starknet messaging protocol enforcement. As mentioned here starknetMessaging.sol The value must be less than 1ether and greater than 0.

Impact

If more or less than the specified value is passed the message would be reverted.

Tools Used

Manual

Recommendations

Validate msg.value

Low-2

Summary

Use safeMint instead of mint as some L1 owner address won't be compatible

Vulnerability Details

The mintFromBridge bridge.sol:208 uses the underlying mint which can't handle if L1 address is smart contract and unaware of token handling.

Impact

Loss of token for such address owner

Tools Used

Manual

Recommendations

Use safeMint and check status