ArkProject: NFT Bridge

Summary

Burning token on source chain is completely ignored when bridging

Vulnerability Details

The protocol gives users/entities option to burn tokens on source chain which will most likely mint tokens on destination chain when bridging which is a common indutsry practice in cross-chain bridges https://github.com/Cyfrin/2024-07-ark-project/blob/273b7b94986d3914d5ee737c99a59ec8728b1517/apps/blockchain/ethereum/src/Bridge.sol#L83

https://github.com/Cyfrin/2024-07-ark-project/blob/273b7b94986d3914d5ee737c99a59ec8728b1517/apps/blockchain/starknet/src/bridge.cairo#L249 so when users set it to true they expect their tokens to be burnt on source chain and minted on destination chain, but this is not the case as there is no where in the code of both bridges does burning of tokens happen when bridging and it wasn't addressed on the contest page or in the natspec. This issue could bring trust issues/integrity questioning to entites/users that use the bridge for different reasons as expectations are not met or addressed, hence affecting users/entites using the bridge that dont want the same token id to be active on both chains.

Impact

Users expectations are not met, possible loss of values to users

Tools Used

Manual Review

Recommendations

Implement the burn logic or scrap it out completely, or at least address it is not active currently