Summary

Should return VALIDATION_FAILED when install validator module in Module Enable Mode flow.

Vulnerability Details

when validateUserOp() is called by EntryPoint, if Module Enable Mode is not used, protocol will first check if the validator is enabled, and return VALIDATION_FAILED if not.

If Module Enable Mode is used, then protocol will try to install the validator, but transaction will revert (in onInstall()) if it fails to do so. Apparently there is inconsistency in between, because this also means the validator is not enabled and protocol should return VALIDATION_FAILED instead.

Impact

VALIDATION_FAILED is not returned to EntryPoint when it should be.

Tools Used

Manual Review

Recommendations

If protocol fails to install validator in Module Enable Mode flow, do not revert but return VALIDATION_FAILED.