Submission Details
Severity:
Code not matching with docs for `executeFromExecutor` function
Summary
In the docs executeFromExecutor function is present like this
function executeFromExecutor(ExecutionMode mode, bytes calldata executionCalldata) external payable onlyExecutorModule withHook returns (bytes[] memory returnData)
But in implemented code it is
function executeFromExecutor(
ExecutionMode mode,
bytes calldata executionCalldata
) external payable onlyExecutorModule withHook withRegistry(msg.sender, MODULE_TYPE_EXECUTOR) returns (bytes[] memory returnData) {
So the code has withRegistry extra.
Impact
The inconsistency between the docs & the code can lead to confusion and it will add unnecessary modifier which might stop valid user transaction if it is not needed.
Recommendation
If this withRegistry modifier is not needed please remove it, or if it is required update the docs accordingly.
Prize pool breakdown
Total prize
30,000 USDC
nSLOC
1,43321 USDC / LOC
25,000 USDC
2,750 USDC
2,250 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.