HardhatFoundry
30,000 USDC
View results
Submission Details
Severity: low
Invalid

`unstakeDelaySec` has no upper limit

Summary

In the Stakeable contract, the unstakeDelaySec parameter in the addStake function has no upper limit, allowing it to be set to any value between 1 second and approximately 1,193,824 hours. This lack of restriction could lead to various issues.

Impact

The absence of a limit on unstakeDelaySec can result in Excessive Lock Periods

Admin could set an excessively high unstake delay, unintentionally or maliciously, causing their funds to be locked for impractically long periods. This can reduce the liquidity & usability of the staked funds.

Recommendation

Implement a reasonable upper for the unstakeDelaySec parameter to ensure it remains within a practical and secure range.

Updates

Lead Judging Commences

0xnevi Lead Judge 12 months ago
Submission Judgement Published
Invalidated
Reason: Known issue
Assigned finding tags:

finding-unchecked-unstakeDelaySec

Invalid, admin input error/call validation per [codehawks guidelines](https://docs.codehawks.com/hawks-auditors/how-to-determine-a-finding-validity#findings-that-may-be-invalid)

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.