In the Stakeable
contract, the unstakeDelaySec
parameter in the addStake
function has no upper limit, allowing it to be set to any value between 1 second and approximately 1,193,824 hours. This lack of restriction could lead to various issues.
The absence of a limit on unstakeDelaySec
can result in Excessive Lock Periods
Admin could set an excessively high unstake delay, unintentionally or maliciously, causing their funds to be locked for impractically long periods. This can reduce the liquidity & usability of the staked funds.
Implement a reasonable upper for the unstakeDelaySec
parameter to ensure it remains within a practical and secure range.
Invalid, admin input error/call validation per [codehawks guidelines](https://docs.codehawks.com/hawks-auditors/how-to-determine-a-finding-validity#findings-that-may-be-invalid)
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.