Biconomy: Nexus

GitHub
https://github.com/Cyfrin/2024-07-biconomy/blob/9590f25cd63f7ad2c54feb618036984774f3879d/contracts/modules/validators/K1Validator.sol#L59-L62

Summary

The onUninstall function includes an unused parameter bytes calldata.

Impact

If calldata is meant to be used then it should be validated, otherwise any random calldata can be passed. Along with this if it is NOT used then the unused parameter adds unnecessary complexity to the function and may confuse developers.

Recommendation

Remove the unused parameter bytes calldata from the function signature if it is not needed. If it is needed, include logic to handle it appropriately.

Corrected function

Alternatively, if the bytes calldata is meant to be used, you should implement the necessary logic to handle it within the function.