SpiceAuction
and DaiGoldAuction
's bid
should have a deadline
or epochId
to prevent users from accidentally bidding on the next auction during slight network congestion.
The bid function lacks deadline protection. During network congestion, some users may end up bidding for the next auction if their transaction is delayed.
Example:
Alice bids for auction X near its end because she likes its terms.
Her transaction gets delayed due to low gas or network congestion.
A new auction Y starts.
Alice's bid transaction finally gets executed, but the bid is for auction Y instead of auction X.
User funds are at risk because slight network congestion can cause users to bid on the wrong auction.
Manual review
Add epochId
to the bid and ensure it matches the current epoch. This will guarantee that users are bidding on the correct auction.
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.